Attention is currently required from: Stefan Reinauer, Thomas Heijligen.
Patch set 5:Code-Review +1
View Change
1 comment:
File meson.build:
Patch Set #5, Line 76:
'mjson.c',
'flashchips.c',
probably the structure should be:
```
imports/mjson/{mjson.c, meson.build} => gen 'mjson.a'.
```
&&
```
flashchipdb/{flashchips.c, flashchips.h, meson.build} => gen flashchips.a
```
this affords us the path to having a feature flag for link-time decision to which db to use - builtin or parsed external. WDYT?
To view, visit change 75648. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I714b35f7c869932924ff50c505ad39cf88cf3950
Gerrit-Change-Number: 75648
Gerrit-PatchSet: 5
Gerrit-Owner: Stefan Reinauer <stefan.reinauer@coreboot.org>
Gerrit-Reviewer: Edward O'Callaghan <quasisec@chromium.org>
Gerrit-Reviewer: Thomas Heijligen <src@posteo.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-Attention: Stefan Reinauer <stefan.reinauer@coreboot.org>
Gerrit-Attention: Thomas Heijligen <src@posteo.de>
Gerrit-Comment-Date: Thu, 08 Jun 2023 03:38:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment