Attention is currently required from: Dhiren Serai.
4 comments:
Commit Message:
Patch Set #1, Line 7: fix scan build make issues
Please don't just refer to scan-build. The issues found by scan-build might be actual issues, but they also could be false-positives. Rather add a short note in the summary below that this was found by scan-build.
However, please use a meaningful commit title so that people get an idea what this commit is about.
scan build make was showing issues with variables using malloc for uninitialized/garbage values.
For fixing that I used calloc which sets allocated memory to zero as default so it will not be uninitialized/garbage
Please wrap the summary at 72 characters. The subject line should be limited to 50 characters. In some cases it can be expanded to 72 characters if there is no other way around it.
I recommend reading this about commit messages in general https://cbea.ms/git-commit.
File sfdp.c:
Patch Set #1, Line 298: hbuf = calloc(8,(nph + 1) * 8);
The buffer gets overridden in spi_sfdp_read_sfdp() anyway, so it doesn't matter much if malloc is used. But I also don't have a strong opinion aginst calloc. Definitely not bad to have zeroed memory 😊
Though, it should be `calloc(8, nph + 1)`.
Add a space before `len`.
To view, visit change 67331. To unsubscribe, or for help writing mail filters, visit settings.