Attention is currently required from: Felix Singer, Nico Huber, Michał Żygowski, Paul Menzel, Sergii Dmytruk.

View Change

3 comments:

• File ite_ec.c:

  • Patch Set #11, Line 735:

    	if (!ec_write_reg(0xf9, 0x20, EC_MAX_STATUS_CHECKS) ||
    	    !ec_write_reg(0xfa, 0x02, EC_MAX_STATUS_CHECKS) ||
    	    !ec_write_reg(0xfb, 0x00, EC_MAX_STATUS_CHECKS) ||
    	    !ec_write_reg(0xf8, 0xb1, EC_MAX_STATUS_CHECKS)) {
    		msg_perr("Unable to initialize controller.\n");
    		return 1;
    	}
    
    

    Added a separate function for this purpose. […]

    Done

• File ite_ecfw.c:

  • Patch Set #14, Line 324: 0xaa

    What zero means in this field then?

    zero means `size of 0`, which is "disable", too but only valid when the mirror bit set. When the mirror bit is 0, only 0xaa is valid here, according to the datasheet

• File ite_ecfw.c:

  • Patch Set #17, Line 142: shutdown

    Shutdown of the programmer not the EC. and Yes, it is wdg reset command that is sent to EC.

    Ack

To view, visit change 55715. To unsubscribe, or for help writing mail filters, visit settings.