Patch set 2:Code-Review +1

View Change

4 comments:

• File it85spi.c:

  • Patch Set #2, Line 76: it85_data

    call this `it85spi_data`

  • Patch Set #2, Line 222:

    
    	return 0
    

    you need to `free(data);` before the return since it is a heap allocation.

  • Patch Set #2, Line 312:

              msg_perr("Out of memory!\n");
              return 1;
            }
    

    ```
                msg_perr("Unable to allocate space for extra SPI master data.\n");
                    return SPI_GENERIC_ERROR;
            }
    ```

  • Patch Set #2, Line 315: data->it85xx_scratch_rom_reenter = 0;

    I know the original code doesn't do it but its probably worth initialising the rest as well.

To view, visit change 47655. To unsubscribe, or for help writing mail filters, visit settings.