Patch Set 6:

Did somebody look into Hatim's patches [1]? I didn't but feel like
we owe them some attention. They cover more than just write protection.
I fear, if we don't look into them now, we never will.

[1] Somewhere amidst

I looked into some of them way back when they were first written, but wasn't doing much work with flashrom at the time so I didn't get involved much. IIRC the only issue I had was that some patches were too generalized, i.e. they made assumptions that were true for some chips but not all. Some large Spansion S25FS and FL chips were particularly odd, and there were cases where "don't care" block protect bits could impact generic methods unexpectedly.

Still, he did a lot of good work and it may be useful to revisit those patches to see if we can salvage some of them. And as you mention they cover more than write protection, there might be some OTP-related patches we can use.

View Change

To view, visit change 40325. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Id93b5a1cb2da476fa8a7dde41d7b963024117474
Gerrit-Change-Number: 40325
Gerrit-PatchSet: 6
Gerrit-Owner: Edward O'Callaghan <>
Gerrit-Reviewer: Matt DeVillier <>
Gerrit-Reviewer: Nikolai Artemiev <>
Gerrit-Reviewer: build bot (Jenkins) <>
Gerrit-CC: Angel Pons <>
Gerrit-CC: Damien Zammit
Gerrit-CC: David Hendricks <>
Gerrit-CC: Nico Huber <>
Gerrit-CC: Paul Menzel <>
Gerrit-CC: Stefan Reinauer <>
Gerrit-Comment-Date: Sun, 05 Jul 2020 17:29:42 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment