View Change

4 comments:

• File nicintel_eeprom.c:

  • Patch Set #1, Line 99: Unprogrammed

    Please put this at the beginning of the string

  • Patch Set #1, Line 109: switch (device_id)

    Why use a switch? This could be simply:

     return device_id == 0x1509 || device_id == 0x151f;

  • Patch Set #1, Line 477: uintptr_t io_base_addr = pcidev_readbar(dev, PCI_BASE_ADDRESS_0);

    This change is probably needed because most PCI devices on x86_64 use 32-bit BARs

• File nicintel_spi.c:

  • Patch Set #1, Line 277: (dev->device_id & 0xfff0) == 0x1510

    This check will be a false positive for 0x1517 and 0x151c

To view, visit change 39963. To unsubscribe, or for help writing mail filters, visit settings.