Attention is currently required from: Felix Singer, Nico Huber, Thomas Heijligen, Angel Pons, Anastasia Klimchuk, Alexander Goncharov.

View Change

1 comment:

• Commit Message:

  • Patch Set #4, Line 13:

    Hmmm, looks like the main source of confusion is lack of documentation regarding flashrom layers and […]

    If the only remaining question is about scoping global variables used within the two custom programmer delay workers then this is trivial to answer. The custom programmer delay functions are programmer specific and therefore their global scope is to that of the programmers unit of work. It directly follows that the programmers data field may therefore be leverage to carry this state and this is thus accessible via the `flashctx`. The dispatch site of `programmer_delay()` that calls into the programmer specific delays simply just needs to pass the ctx into the callbacks, this is a trivial signature change to `void (*delay) (unsigned int usecs); -> void (*delay) (const struct flashctx *flash, unsigned int usecs);` with both the `par_master` and `spi_master` struct's. Certainly nothing to do with confusion of flashrom layers or structures.

To view, visit change 67393. To unsubscribe, or for help writing mail filters, visit settings.