Attention is currently required from: Nikolai Artemiev.
View Change
1 comment:
Commit Message:
Patch Set #1, Line 9: DIY memset
This would be useful in case any layout fields have to be initialized to a non-zero value on an empt […]
Yea I saw that however looks like 'code for the future' so right now it is better to not have such clever tricks. I agree also with the latter point you made too.
To view, visit change 68279. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Id6cf2c4591aec0620f15d8a39495d2bff6597f96
Gerrit-Change-Number: 68279
Gerrit-PatchSet: 1
Gerrit-Owner: Edward O'Callaghan <quasisec@chromium.org>
Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: Nikolai Artemiev <nartemiev@google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-Attention: Nikolai Artemiev <nartemiev@google.com>
Gerrit-Comment-Date: Tue, 11 Oct 2022 09:41:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons <th3fanbus@gmail.com>
Gerrit-MessageType: comment