Attention is currently required from: Anton Samsonov, David Hendricks, Matt DeVillier.
1 comment:
Patchset:
> There are certainly cases where there is no harm in selecting the first chip of multiple. […]
Anton, thank you so much for joining. You have many useful ideas!
I am not doing anything right now because I am thinking what is the right thing to do here.
I fully understand the problem Matt is trying to solve, the IDs are repeating, more and more with time (because we never remove chip definitions, we only add new ones).
I want to make SFDP detection more smooth next year but in any case this does not cover old chips.
About the idea to use first chip: I still hold my initial opinion that this is a dangerous option in general, if we look at all the variety of use cases how people use flashrom and on which environments. However if we narrow down the use case, I understand that there is a use case when this option is fine. And actually, Matt's userbase is mostly belong to that category.
I don't currently have a good idea whether it is possible to add this option so that "safe target audience" would be using it, and everyone else would know it is dangerous and won't.
Maybe there is no safe way to add such option on upstream.
Let's keep this patch here for a while? As I said, repeated IDs are real, and this is something on my mind to improve. It was very interesting to me to read Anton's thoughts.
To view, visit change 85160. To unsubscribe, or for help writing mail filters, visit settings.