Attention is currently required from: Nico Huber, Angel Pons, Anastasia Klimchuk.
1 comment:
File pickit2_spi.c:
Patch Set #1, Line 343: static struct spi_master spi_master_pickit2 = {
This will bug me with every single patch. I think the API is just broken […]
Same and this is something Anastasia and I actively discussed.
I suggested to Anastasia to focus on getting the easier boilerplate-like patches such as this one front loaded before moving forwards with the API change so that it is well informed, primarily by building heuristic. There were a few edge cases Anastasia identified upon reflection and so we wanted to bring the tree into a more consistent state.
Specifically, two main things:
i) get all the drivers to be reentrant by leveraging data in a consistent manner,
ii) untangle the purpose of shutdown such that its purpose singular in its duties.
One other dimension suggested was that the testing efforts running in tandem to this should be easier to write and have larger cov once drivers follow a more consistent pattern. The data field was a great introduction however was never fully realised so we agreed this would be a good milestone to achieve.
I'll let Anastasia talk to the precise details however I wanted to chime in here Nico so you perhaps get some visibility into the strategy set out to help Anastasia make consistent progress.
To view, visit change 52774. To unsubscribe, or for help writing mail filters, visit settings.