Attention is currently required from: Edward O'Callaghan, Angel Pons.

View Change

4 comments:

• Patchset:

  • Patch Set #3:

    thank you for review!

• File ft2232_spi.c:

  • Patch Set #2, Line 614: spi_data = calloc(1, sizeof(struct ft2232_data));

    Can calloc() fail?

    yes of course, this is my miss

  • Patch Set #2, Line 614: sizeof(struct ft2232_data)

    Using type names in sizeof() is discouraged. […]

    Thank you! This now looks even better.
    I will remember this for future.

  • Patch Set #2, Line 617: memcpy(&spi_data->ftdic_context, &ftdic, sizeof(struct ftdi_context));

    It should be possible to do a direct assignment: […]

    Direct assignment seems to work.

To view, visit change 52256. To unsubscribe, or for help writing mail filters, visit settings.