Attention is currently required from: Nico Huber, Paul Menzel, Edward O'Callaghan, Angel Pons, Anastasia Klimchuk, Sergii Dmytruk.

View Change

4 comments:

• File cli_classic.c:

  • Patch Set #7, Line 63: mode

    What <mode> is? I think this needs explanation, if someone runs `flashrom -h` they need to be able t […]

    Since permanent and powercycle protection are very rarely supported and not very useful, I think we should just drop the mode parameter for now.

    If anyone knows of a case where it would be useful let me know. I've dropped support for it in patchset #10 but I can bring it back from #9.

  • Patch Set #7, Line 222: if (!any_wp_op) return 0;

    any_wp_op seems like a duplication of information, you could check if any of commands is present?

    Done

  • Patch Set #7, Line 257: return ret;

    Please move conditional body on the new line (and same for all other occurrences like this).

    Done

  • Patch Set #7, Line 920: goto out_release;

    and the ones like this too, please move on a new line

    Done

To view, visit change 58738. To unsubscribe, or for help writing mail filters, visit settings.