Nico Huber submitted this change.

View Change

Approvals: build bot (Jenkins): Verified Nico Huber: Looks good to me, approved Angel Pons: Looks good to me, approved
Makefile: meson.build: remove unused CONFIG_I2C_SUPPORT

CONFIG_I2C_SUPPORT has no mention in the source code. No need to pass
it to the compiler.

Change-Id: I2e19335e1b8d39f44dda14edc0a496dda6bc8c9c
Signed-off-by: Thomas Heijligen <thomas.heijligen@secunet.com>
Reviewed-on: https://review.coreboot.org/c/flashrom/+/58495
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Nico Huber <nico.h@gmx.de>
Reviewed-by: Angel Pons <th3fanbus@gmail.com>
---
M Makefile
M meson.build
2 files changed, 0 insertions(+), 2 deletions(-)

diff --git a/Makefile b/Makefile
index b03ab7c..0b60de2 100644
--- a/Makefile
+++ b/Makefile
@@ -738,7 +738,6 @@

ifeq ($(CONFIG_LINUX_I2C_HELPER), yes)
LIB_OBJS += i2c_helper_linux.o
-FEATURE_CFLAGS += -D'CONFIG_I2C_SUPPORT=1'
endif

ifneq ($(NEED_SERIAL), )
diff --git a/meson.build b/meson.build
index 86657ce..85f40ba 100644
--- a/meson.build
+++ b/meson.build
@@ -342,7 +342,6 @@

if host_machine.system() == 'linux'
srcs += 'i2c_helper_linux.c'
- cargs += '-DCONFIG_I2C_SUPPORT=1'
endif

# raw memory, MSR or PCI port I/O access

4 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one.

To view, visit change 58495. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I2e19335e1b8d39f44dda14edc0a496dda6bc8c9c
Gerrit-Change-Number: 58495
Gerrit-PatchSet: 7
Gerrit-Owner: Thomas Heijligen <src@posteo.de>
Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h@gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter@mailbox.org>
Gerrit-MessageType: merged