Attention is currently required from: Aarya, Daniel Campello.
View Change
1 comment:
Patchset:
Patch Set #3:
Hello Aarya and everyone, I am looking at this patch right now and I think to mark it abandoned. Firstly because it seems like it is indeed, but also because I am planning to change the progress indicator soon-ish (next year).
I understand the idea of the patch, but I want to start from different side: for example I don't think the word "completed" needs to be repeated with every % , and same for operation name (it is enough to say READ started... READ completed, without repeating it with every %). After that maybe the issue this patch is trying to solve, will go away naturally.
And in any case, thanks everyone for the effort <3
To view, visit change 64668. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: flashrom
Gerrit-Branch: main
Gerrit-Change-Id: If982193f9857f0da47cd71706ce6cebaa60d4323
Gerrit-Change-Number: 64668
Gerrit-PatchSet: 3
Gerrit-Owner: Aarya <aarya.chaumal@gmail.com>
Gerrit-Reviewer: Anastasia Klimchuk <aklm@chromium.org>
Gerrit-Reviewer: Daniel Campello <campello@chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Evan Benn <evanbenn@google.com>
Gerrit-CC: Paul Menzel <paulepanter@mailbox.org>
Gerrit-CC: Richard Hughes <richard@hughsie.com>
Gerrit-CC: Stefan Reinauer <stefan.reinauer@coreboot.org>
Gerrit-CC: Thomas Heijligen <src@posteo.de>
Gerrit-Attention: Daniel Campello <campello@chromium.org>
Gerrit-Attention: Aarya <aarya.chaumal@gmail.com>
Gerrit-Comment-Date: Sun, 03 Dec 2023 07:48:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment