Attention is currently required from: Edward O'Callaghan, Angel Pons, Anastasia Klimchuk.

View Change

1 comment:

• File tests/tests.c:

  • Patch Set #6, Line 102:

    return ((port == 0x2e /* MEC1308_SIO_PORT1 */
    			|| port == 0x4e /* MEC1308_SIO_PORT2 */)
    		? 0x20 /* MEC1308_DEVICE_ID_REG */
    		: ((outb_val == 0x84 /* MEC1308_MBX_DATA_START */)
    			? 0xaa /* MEC1308_CMD_PASSTHRU_SUCCESS */
    			: 0));
    

    I think I mentioned something about a set of function pointers per tested programmer […]

    So, CB:52604 is what I had in mind. Feel free to take it over if
    it looks useful. The inb/inw/inl pointers are probably not needed
    if we'd decide to use will_return()/mock() instead.

To view, visit change 51487. To unsubscribe, or for help writing mail filters, visit settings.