Attention is currently required from: Riku Viitanen.
3 comments:
Commit Message:
Reviewed-on: https://review.sourcearcade.org/c/flashprog/+/52
Reviewed-by: Nico Huber <nico.h@gmx.de>
Tested-by: Nico Huber <nico.h@gmx.de>
These tags seem to come from another project, you don't need to copy them here, just remove. At the end of review, Gerrit will add the info with the user(s) who done review in the repo.
The only thing which can be useful to keep, is the link to another code review. You can add it in commit message without a tag, like you did in your other patch. This way if anyone is interested, they can click the link and see the info.
Patchset:
Thank you so much for clean up documentation!
There are few more things that I wanted to say about it.
I am happy for this patch to get finished and merged (see my other two small comments).
But the next thing I would do is create a serprog page in the actual documentation directory, `/doc`.
We are in process of moving documentation from wiki to `/doc` in the tree, so that's very relevant. I can do the boring part of converting content of this txt file into rst format, adding page to index etc. Would you review the page? Thank you! It would be the same content as it is txt file now (and txt file will be deleted after that).
The only thing I am still deciding, where is the best place for Programmers docs, whether it's inside Users documentation or separate item in the root menu. What do you think, which place better? :)
All docs are generated into htmls and displayed here https://www.flashrom.org/index.html so you can see how it will look eventually.
File Documentation/serprog-protocol.txt:
Patch Set #1, Line 106: serprog.h
Maybe change to `serprog.c` ? Since .h does not exist, more info is in the source code itself.
To view, visit change 80499. To unsubscribe, or for help writing mail filters, visit settings.