Edward O'Callaghan submitted this change.

View Change

Approvals: build bot (Jenkins): Verified Angel Pons: Looks good to me, approved Anastasia Klimchuk: Looks good to me, but someone else must approve
drkaiser.c: Reshuffle to remove forward declarations

BUG=none
BRANCH=none
TEST=builds

Change-Id: Iee550dc8055eabfe8c7c4ad32003b6eec4f1e496
Signed-off-by: Edward O'Callaghan <quasisec@google.com>
Reviewed-on: https://review.coreboot.org/c/flashrom/+/54850
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Angel Pons <th3fanbus@gmail.com>
Reviewed-by: Anastasia Klimchuk <aklm@chromium.org>
---
M drkaiser.c
1 file changed, 10 insertions(+), 14 deletions(-)

diff --git a/drkaiser.c b/drkaiser.c
index fa562b4..4858b35 100644
--- a/drkaiser.c
+++ b/drkaiser.c
@@ -38,9 +38,17 @@
static uint8_t *drkaiser_bar;

static void drkaiser_chip_writeb(const struct flashctx *flash, uint8_t val,
- chipaddr addr);
+ chipaddr addr)
+{
+ pci_mmio_writeb(val, drkaiser_bar + (addr & DRKAISER_MEMMAP_MASK));
+}
+
static uint8_t drkaiser_chip_readb(const struct flashctx *flash,
- const chipaddr addr);
+ const chipaddr addr)
+{
+ return pci_mmio_readb(drkaiser_bar + (addr & DRKAISER_MEMMAP_MASK));
+}
+
static const struct par_master par_master_drkaiser = {
.chip_readb = drkaiser_chip_readb,
.chip_readw = fallback_chip_readw,
@@ -81,15 +89,3 @@

return 0;
}
-
-static void drkaiser_chip_writeb(const struct flashctx *flash, uint8_t val,
- chipaddr addr)
-{
- pci_mmio_writeb(val, drkaiser_bar + (addr & DRKAISER_MEMMAP_MASK));
-}
-
-static uint8_t drkaiser_chip_readb(const struct flashctx *flash,
- const chipaddr addr)
-{
- return pci_mmio_readb(drkaiser_bar + (addr & DRKAISER_MEMMAP_MASK));
-}

To view, visit change 54850. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Iee550dc8055eabfe8c7c4ad32003b6eec4f1e496
Gerrit-Change-Number: 54850
Gerrit-PatchSet: 3
Gerrit-Owner: Edward O'Callaghan <quasisec@chromium.org>
Gerrit-Reviewer: Anastasia Klimchuk <aklm@chromium.org>
Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: Edward O'Callaghan <quasisec@chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-MessageType: merged