Attention is currently required from: Nico Huber, Edward O'Callaghan, Angel Pons.

View Change

2 comments:

• File buspirate_spi.c:

  • Patch Set #3, Line 329:

    	unsigned char *bp_commbuf = NULL;
    	int bp_commbufsize = 0;
    
    

    Nit, `NULL`/`0` should never be consumed, so the initializations are unnecessary.

    Done

  • Patch Set #3, Line 695:

    	/* Storing the latest values into data, commbuf migth have grown during init. */
    	bp_data->bp_commbuf = bp_commbuf;
    	bp_data->bp_commbufsize = bp_commbufsize;
    

    In the light of the discussion above, this shouldn't be needed?

    Yes, right - because it is done right after buspirate_commbuf_grow and no need to do this anymore, the pointer and the size won't change (only buspirate_commbuf_grow changes them).

To view, visit change 52958. To unsubscribe, or for help writing mail filters, visit settings.