Nico Huber submitted this change.

View Change

Approvals: build bot (Jenkins): Verified Nico Huber: Looks good to me, approved
tests: Move LOG_ME to include/tests.h to be available everywhere

LOG_ME macro is very generic and can be useful anywhere in tests.
Previously was only used in scope of tests.c. With time more tests
are added, and more files, LOG_ME needs to be visible everywhere.

BUG=b:181803212
TEST=builds and ninja test

Change-Id: If7f3d256161bc8b81e996328e445cccab9a82174
Signed-off-by: Anastasia Klimchuk <aklm@chromium.org>
Reviewed-on: https://review.coreboot.org/c/flashrom/+/57914
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Nico Huber <nico.h@gmx.de>
---
M tests/include/test.h
M tests/tests.c
2 files changed, 2 insertions(+), 3 deletions(-)

diff --git a/tests/include/test.h b/tests/include/test.h
index ee7b4cf..bf8c4f7 100644
--- a/tests/include/test.h
+++ b/tests/include/test.h
@@ -35,4 +35,6 @@
*/
void *not_null(void);

+#define LOG_ME printf("%s is called\n", __func__)
+
#endif /* _TESTS_TEST_H */
diff --git a/tests/tests.c b/tests/tests.c
index 9dadddf..329e798 100644
--- a/tests/tests.c
+++ b/tests/tests.c
@@ -21,9 +21,6 @@
#include <string.h>
#include <stdint.h>

-/* redefinitions/wrapping */
-#define LOG_ME printf("%s is called\n", __func__)
-
void *not_null(void)
{
return (void *)NON_ZERO;

4 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one.

To view, visit change 57914. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: If7f3d256161bc8b81e996328e445cccab9a82174
Gerrit-Change-Number: 57914
Gerrit-PatchSet: 6
Gerrit-Owner: Anastasia Klimchuk <aklm@chromium.org>
Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: Edward O'Callaghan <quasisec@chromium.org>
Gerrit-Reviewer: Nico Huber <nico.h@gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter@mailbox.org>
Gerrit-MessageType: merged