Attention is currently required from: Subrata Banik, Nico Huber, Angel Pons, Anastasia Klimchuk.
View Change
1 comment:
Commit Message:
Patch Set #6, Line 10: during the data portion of the SPI cycle.
My understanding is that renaming is needed for the next patch CB:62892 which introduces `HSFC_FDBC(n)`. Subrata please correct me if I am wrong?
you are right Anastasia. Also, I agree with Nico, that macro name/variable names are personal preference for developer hence, with respect to them, IMO this CL renames those macros in meaningful ways to show its true purpose as "HSFC_FDBC_MASK macro represents the number of bytes to shift in or out
during the data portion of the SPI cycle." so, better we use it for masking.
To view, visit change 62894. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Ia0ae9a586b5c12f0229334898426175ec246a70c
Gerrit-Change-Number: 62894
Gerrit-PatchSet: 8
Gerrit-Owner: Subrata Banik <subratabanik@google.com>
Gerrit-Reviewer: Anastasia Klimchuk <aklm@chromium.org>
Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: Edward O'Callaghan <quasisec@chromium.org>
Gerrit-Reviewer: Nico Huber <nico.h@gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter@mailbox.org>
Gerrit-CC: Subrata Banik <subi.banik@gmail.com>
Gerrit-Attention: Subrata Banik <subi.banik@gmail.com>
Gerrit-Attention: Nico Huber <nico.h@gmx.de>
Gerrit-Attention: Angel Pons <th3fanbus@gmail.com>
Gerrit-Attention: Anastasia Klimchuk <aklm@chromium.org>
Gerrit-Comment-Date: Wed, 13 Apr 2022 05:28:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber <nico.h@gmx.de>
Comment-In-Reply-To: Subrata Banik <subratabanik@google.com>
Comment-In-Reply-To: Angel Pons <th3fanbus@gmail.com>
Comment-In-Reply-To: Anastasia Klimchuk <aklm@chromium.org>
Gerrit-MessageType: comment