Looks good but I fear some things have to change. At least the `transferred`
pointer to libusb_interrupt_transfer() and the missing libusb_exit().

If it's not too much trouble, it would be nice to retest, but only after the
review is done. Doesn't have to cover a whole flash, a layout that covers two
or more erase blocks with `--noverify-all` could speed things up. `--fmap` is
also a nice test for nearly abitratry reads (if the FMAP is hard to find, i.e.
not at a naturally aligned location).

Two things were noticed during review that should be fixed across all libusb
programmers in the future:

View Change

10 comments:

To view, visit change 32213. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Icfc5372aa1789d35ed22d68297d5e68a74d40388
Gerrit-Change-Number: 32213
Gerrit-PatchSet: 7
Gerrit-Owner: Thomas Heijligen <src@posteo.de>
Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: HAOUAS Elyes <ehaouas@noos.fr>
Gerrit-Reviewer: Marius Genheimer <mail@f0wl.cc>
Gerrit-Reviewer: Nico Huber <nico.h@gmx.de>
Gerrit-Reviewer: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-Reviewer: Thomas Heijligen <src@posteo.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-Comment-Date: Sat, 06 Jul 2019 17:56:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment