Attention is currently required from: David Hendricks, Edward O'Callaghan, Angel Pons, Anastasia Klimchuk.
Patch set 6:Code-Review +1
5 comments:
Patchset:
Even better news: now after adding includes in meson. […]
This looks quite nice now, thank you!
Only one remark, the -DUNIT_TESt_ENV. Do we still need it?
About `unittest.h`, I'm not sure if I fully understood its role. Maybe
the idea is to not test allocations that are done by the tests itself?
i.e. the tests itself wouldn't have to be error free, only the tested
code has to be. As long as the tests work, that's fine. Just something
to keep in mind if the tests ever get more complex.
File meson.build:
Patch Set #6, Line 477: -include
Can we have spaces after -include? That should work, I guess :)
File tests/flashrom.c:
Patch Set #2, Line 27: #define assert_string_not_equal_with_free(text, expected) \
I tried to make it better, dropped _string (7 chars) and replaced free->and (1 char) so in total I r […]
Looks better indeed.
File tests/helpers.c:
Patch Set #6, Line 21: #include <stdlib.h>
I'm not sure if we should remove this. The files under tests/
shouldn't have the -include arguments, right? It's probably
indirectly included by one of the header files above.
File tests/meson.build:
Patch Set #6, Line 38: '-DUNIT_TEST_ENV',
Is this still needed? Now that `unittest_env.h` is only when building
for tests, it seems redundant.
To view, visit change 51243. To unsubscribe, or for help writing mail filters, visit settings.