Attention is currently required from: Thomas Heijligen, Anastasia Klimchuk.

View Change

1 comment:

• File tests/lifecycle.c:

  • Patch Set #4, Line 34: flashrom_flash_release(flashctx); /* cleanup */

    Or aborts `assert_int_equal` the test?

    I was about to ask the same question :)

    If this line is executed on failure too, we need the `NULL` initialization
    because flashrom_flash_probe() might not set any value on failure (unless
    documented otherwise). If it's not executed, the value doesn't matter ofc.

To view, visit change 59741. To unsubscribe, or for help writing mail filters, visit settings.