David Hendricks posted comments on this change.

View Change

Patch set 2:Code-Review +2

Small nit, otherwise LGTM.

(1 comment)

• File flash.h:

  • Patch Set #2, Line 241:

    	int address_high_byte;
    	bool in_4ba_mode;
    

    A comment above these should be added to clarify how they affect the way the high address byte is communicated to the chip. Basically just restate here what you have in the commit message.

To view, visit change 22384. To unsubscribe, visit settings.