View Change

2 comments:

• Commit Message:

  • Patch Set #4, Line 9:

    The write protection trigger has been updated by the vendor so update
    here as well.
    

    Please add a little more detail for external reviewers so that everyone understands the code well and folks can look back in git history to understand it as well.

    Also please add BUG/BRANCH=puff and TEST lines.

• File realtek_mst_i2c_spi.c:

  • Patch Set #4, Line 49: HIGH

    perhaps, 'HIGHBYTE' also leave out the `_WP_` part.

    Alternatively, just write `#define GPIO_CONFIG_ADDRESS 0x104F` and use `(GPIO_CONFIG_ADDRESS>>8)` to get the high byte and the cast will auto give you the low byte.

To view, visit change 46089. To unsubscribe, or for help writing mail filters, visit settings.