Attention is currently required from: Thomas Heijligen.
View Change
1 comment:
File meson.build:
Patch Set #3, Line 357: error('RAW access is not available on non-x86 platforms. Disable the programmer which needs it. Use `meson build -Dpciutils=false -Dconfig_rayer_spi=false`')
I don't think this is accurate, because PCI-based programmers work on non-x86 platforms but simply l […]
A relatively simple fix might be to move the stub implementation into the header as an inline static function. As-is the organization seems incorrect since the non-x86 stub is currently in the "_x86" C file.
To view, visit change 61198. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Iafabe8b4b2a95697773a739501dfc62d880d3f6d
Gerrit-Change-Number: 61198
Gerrit-PatchSet: 3
Gerrit-Owner: Thomas Heijligen <src@posteo.de>
Gerrit-Reviewer: Edward O'Callaghan <quasisec@chromium.org>
Gerrit-Reviewer: Felix Singer <felixsinger@posteo.net>
Gerrit-Reviewer: Nico Huber <nico.h@gmx.de>
Gerrit-Reviewer: Peter Marheine <pmarheine@chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Anastasia Klimchuk <aklm@chromium.org>
Gerrit-CC: Paul Menzel <paulepanter@mailbox.org>
Gerrit-Attention: Thomas Heijligen <src@posteo.de>
Gerrit-Comment-Date: Thu, 20 Jan 2022 01:57:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Peter Marheine <pmarheine@chromium.org>
Gerrit-MessageType: comment