Attention is currently required from: Nico Huber, Edward O'Callaghan, Angel Pons, Anastasia Klimchuk.
3 comments:
File writeprotect.c:
Patch Set #6, Line 26: print_wp_chip_state
You can move print_wp_chip_state here on the top, and avoid forward declaration.
I think it's a bit nicer to keep it with the other printing functions that get added at the bottom of the file.
Alternatively I can change it to a function that writes to a string and declare it in the header since that would be somewhat useful for wp users.
static int read_reg_bit(
const struct flashctx *flash,
const struct reg_bit_info bit,
uint8_t *value,
bool *present)
Just to check: does this not fit into 112 chars? It really helps to grep when all parameters are on […]
Done
Patch Set #6, Line 73: void *suppress_unused_warning_for_read_wp_chip_state = read_wp_chip_state;
This merely avoids a warning about the `read_wp_chip_state()` function being unused. […]
I can move the read/write functions into another commit if it really would be easier to review them that way, but they are helper functions that get used in several places so they don't really belong with any other change.
They are also quite complicated but do a well defined task so I thought it would be easier to them review them on their own.
To view, visit change 58479. To unsubscribe, or for help writing mail filters, visit settings.