Attention is currently required from: Thomas Heijligen.
View Change
1 comment:
File Makefile:
Patch Set #5, Line 594: CONFIG_INTERNAL_X86 := yes
Shouldn't it be the other way around, i.e. CONFIG_INTERNAL needs to be
disabled on x86 if CONFIG_INTERNAL_X86 is disabled (because of missing
dependencies)? What happens with the current version on x86/linux if
libpci is missing for instance?
To view, visit change 61300. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Ia607ea60c3d7d15fe231fa412595992dadc535ad
Gerrit-Change-Number: 61300
Gerrit-PatchSet: 5
Gerrit-Owner: Thomas Heijligen <src@posteo.de>
Gerrit-Reviewer: Nico Huber <nico.h@gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Felix Singer <felixsinger@posteo.net>
Gerrit-CC: Paul Menzel <paulepanter@mailbox.org>
Gerrit-CC: Peter Marheine <pmarheine@chromium.org>
Gerrit-Attention: Thomas Heijligen <src@posteo.de>
Gerrit-Comment-Date: Sat, 19 Feb 2022 13:03:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment