Nico Huber posted comments on this change.

View Change

Patch set 2:

(3 comments)

• File chipset_enable.c:

  • Patch Set #2, Line 836: and

    s/and/or/? (ich you read the identifier as a statement...)

• File ich_descriptors.c:

  • Patch Set #2, Line 76:

    		else
    			return -1;
    

    You could remove both else paths and just return -1 at the end.

• File ichspi.c:

  • Patch Set #2, Line 1703: num_freg = 12; /* 12 MMIO regs, but 16 regions in FD spec */

    Depending on what the regular PCH returns for the register addresses,

    10 is correct, the registers read with 0x00007fff just what is set
    in the descriptor.

    12 would work too for the regular PCH (registers read 0 and are
    ignored by the current code).

To view, visit change 20922. To unsubscribe, visit settings.