Stefan Tauner posted comments on this change.

View Change

Patch set 3:

Well, one thing that I advise other ppl. when one of their commit
get
bikeshedded for doing something unrelated: Change the commit
message
to include all the changes.

In this case, I will remove the -2 if you agree to name the final
commit "Convert flashrom to git and cosmetic changes" or something
better that covers all the unrelated stuff ;-)

I had prepared an updated commit log anyway in an empty commit squash commit... no idea where that went. Maybe gerrit ate it.

To view, visit change 21837. To unsubscribe, visit settings.

Gerrit-Project: flashrom
Gerrit-Branch: staging
Gerrit-MessageType: comment
Gerrit-Change-Id: I2f84d9db2ec3247f313573c5fcd8b9b758ab9d96
Gerrit-Change-Number: 21837
Gerrit-PatchSet: 3
Gerrit-Owner: Stefan Tauner <stefan.tauner@gmx.at>
Gerrit-Reviewer: David Hendricks <david.hendricks@gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h@gmx.de>
Gerrit-Reviewer: Stefan Tauner <stefan.tauner@gmx.at>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-Comment-Date: Wed, 04 Oct 2017 23:50:48 +0000
Gerrit-HasComments: No