Patrick Georgi submitted this change.

View Change


Approvals: build bot (Jenkins): Verified Felix Singer: Looks good to me, approved
test_build.sh: Improve robustness when dealing with empty $CC

Add quotes so that = knows what to compare, otherwise the shell
complains:

./test_build.sh: 16: [: =: unexpected operator

Change-Id: Ia289b31291949f5cbc11484b8f1a7cb7a49bd2bb
Signed-off-by: Patrick Georgi <pgeorgi@google.com>
Reviewed-on: https://review.coreboot.org/c/flashrom/+/67740
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Felix Singer <felixsinger@posteo.net>
---
M test_build.sh
1 file changed, 19 insertions(+), 1 deletion(-)

diff --git a/test_build.sh b/test_build.sh
index 4d6570b..0a4506a 100755
--- a/test_build.sh
+++ b/test_build.sh
@@ -13,7 +13,7 @@
CH341A_SPI DIGILENT_SPI JLINK_SPI"


-if [ $(basename "${CC}") = "ccc-analyzer" ] || [ -n "${COVERITY_OUTPUT}" ]; then
+if [ "$(basename "${CC}")" = "ccc-analyzer" ] || [ -n "${COVERITY_OUTPUT}" ]; then
is_scan_build_env=1
fi


To view, visit change 67740. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Ia289b31291949f5cbc11484b8f1a7cb7a49bd2bb
Gerrit-Change-Number: 67740
Gerrit-PatchSet: 2
Gerrit-Owner: Patrick Georgi <patrick@coreboot.org>
Gerrit-Reviewer: Felix Singer <felixsinger@posteo.net>
Gerrit-Reviewer: Patrick Georgi <patrick@coreboot.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-MessageType: merged