So here is a +1 for overall sanity of the implementation. I still don't
like the syntax and non-positional argument story. And if we don't keep
full compatibility, I'd rather start over with a stricter, more expli-
cit and easier to parse syntax.

But if the two of you want it in, go ahead. The manpage still seems to
miss the fact that the filename argument is non-positional btw.

Patch set 13:Code-Review +1

View Change

To view, visit change 23022. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iefbcb7dc4fefe26f5afd1292dfd5c1687fa62803
Gerrit-Change-Number: 23022
Gerrit-PatchSet: 13
Gerrit-Owner: David Hendricks <david.hendricks@gmail.com>
Gerrit-Reviewer: Arthur Heymans <arthur@aheymans.xyz>
Gerrit-Reviewer: David Hendricks <david.hendricks@gmail.com>
Gerrit-Reviewer: Louis Yung-Chieh Lo <yjlou@chromium.org>
Gerrit-Reviewer: Nico Huber <nico.h@gmx.de>
Gerrit-Reviewer: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-Comment-Date: Sun, 24 Jun 2018 18:11:24 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: Yes