7 comments:
Patch Set #1, Line 641: s25f.o
Make adding the file and putting it into the makefile its own patch. Also don't forget to add it to meson as well.
Patch Set #1, Line 24: #include "writeprotect.h" /* for modifier_bits */
unrelated.
struct flashrom_flashctx;
#define flashctx flashrom_flashctx /* TODO: Agree on a name and convert all occurences. */
can you make this move its own patch, nice and simple one.
#define CHIP_RESTORE_CALLBACK int (*func) (struct flashctx *flash, uint8_t status)
int register_chip_restore(CHIP_RESTORE_CALLBACK, struct flashctx *flash, uint8_t status);
add this chip_restore support into its own patch.
#define CHIP_RESTORE_MAXFN 4
static int chip_restore_fn_count = 0;
static struct chip_restore_func_data {
CHIP_RESTORE_CALLBACK;
struct flashctx *flash;
uint8_t status;
} chip_restore_fn[CHIP_RESTORE_MAXFN];
chip restore patch
//int register_chip_restore(int (*function) (void *data), void *data)
int register_chip_restore(CHIP_RESTORE_CALLBACK,
struct flashctx *flash, uint8_t status)
{
if (chip_restore_fn_count >= CHIP_RESTORE_MAXFN) {
msg_perr("Tried to register more than %i chip restore"
" functions.\n", CHIP_RESTORE_MAXFN);
return 1;
}
chip_restore_fn[chip_restore_fn_count].func = func; /* from macro */
chip_restore_fn[chip_restore_fn_count].flash = flash;
chip_restore_fn[chip_restore_fn_count].status = status;
chip_restore_fn_count++;
return 0;
}
chip restore patch
probably need to call chip restore here?
To view, visit change 46140. To unsubscribe, or for help writing mail filters, visit settings.