Nico Huber merged this change.

View Change

Approvals: Nico Huber: Looks good to me, approved build bot (Jenkins): Verified
fixup! Convert flashrom to git

- update the commit-msg to check for duplicate signoffs/acks

Change-Id: Ia36147e673cceb6d175884b40d4bdd00015b96dc
Signed-off-by: Stefan Tauner <stefan.tauner@gmx.at>
Reviewed-on: https://review.coreboot.org/21833
Reviewed-by: Nico Huber <nico.h@gmx.de>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
---
M util/git-hooks/commit-msg
1 file changed, 18 insertions(+), 1 deletion(-)

diff --git a/util/git-hooks/commit-msg b/util/git-hooks/commit-msg
index 3b3d541..b9217e0 100755
--- a/util/git-hooks/commit-msg
+++ b/util/git-hooks/commit-msg
@@ -6,6 +6,10 @@
#
# Copyright (C) 2009 The Android Open Source Project
#
+# Any other changes including test_duplicate_signoffs_acks
+#
+# Copyright (C) 2017 Stefan Tauner
+#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
@@ -188,5 +192,18 @@
git hash-object -t commit --stdin
}

+# Test for duplicate signoffs/acks
+test_duplicate_signoffs_acks() {
+ test "" = "$(grep -i '^(Signed-off-by|Acked-by): ' "$MSG" |
+ sort | uniq -c | sed -e '/^[[:space:]]*1[[:space:]]/d')" || {
+ echo "Duplicate Signed-off-by or Acked-by lines." >&2
+ exit 1
+ }
+}

-add_ChangeId
+main() {
+ test_duplicate_signoffs_acks
+ add_ChangeId
+}
+
+main

To view, visit change 21833. To unsubscribe, visit settings.

Gerrit-Project: flashrom
Gerrit-Branch: staging
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia36147e673cceb6d175884b40d4bdd00015b96dc
Gerrit-Change-Number: 21833
Gerrit-PatchSet: 5
Gerrit-Owner: Stefan Tauner <stefan.tauner@gmx.at>
Gerrit-Reviewer: Nico Huber <nico.h@gmx.de>
Gerrit-Reviewer: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>