Stefan Tauner posted comments on this change.

View Change

Patch set 1:

Scratch that. -U is pretty old, this fixup is completely unrelated
to
the commit it fixes up?

Well, not completely completely. In my initial patch that included the version string and upcache it was also changed to -u and I still think it's a good and tiny change.

I don't have *any* reservations regarding backward compatibility of this script's parameters because I bet no one but the makefile is using it yet and it simply does not make sense to have an upper-case parameter in its current form so there is really no reason to NOT change it IMHO even if it seems "unrelated" or useless. I don't see how a -2 would be warranted apart from expressing anger about the extensive bike shedding ;)

To view, visit change 21837. To unsubscribe, visit settings.

Gerrit-Project: flashrom
Gerrit-Branch: staging
Gerrit-MessageType: comment
Gerrit-Change-Id: I2f84d9db2ec3247f313573c5fcd8b9b758ab9d96
Gerrit-Change-Number: 21837
Gerrit-PatchSet: 1
Gerrit-Owner: Stefan Tauner <stefan.tauner@gmx.at>
Gerrit-Reviewer: David Hendricks <david.hendricks@gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h@gmx.de>
Gerrit-Reviewer: Stefan Tauner <stefan.tauner@gmx.at>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-Comment-Date: Wed, 04 Oct 2017 01:33:16 +0000
Gerrit-HasComments: No