Attention is currently required from: Felix Singer, Thomas Heijligen, Angel Pons.

1 comment:

File tests/meson.build:
- Patch Set #10, Line 32:
```
  p_data += {
    'testsrc' : p_data.get('testsrc', []),
  }
  srcs += p_data.get('testsrc')
```
  Just rethinking.. […]
  I came up with one question, wanted to clarify. At the moment we need all test files to be included in the build, regardless of whether programmer is enabled or not. Does this work like that?
  Another thought, relevant to this patch and also another one:
  why https://review.coreboot.org/c/flashrom/+/67664/5 (PS5, *not* the recent patchset) passed the jenkins? I would assume it should not, because line 43 in PS5 skips the wrong test?
  I checked test_build script, and I see it is running tests in the loop, each time one programmer enabled. In my mind, the tests where ch341a_spi is disabled should fail to build (to link) on 67664/5 but that didn't happen? I am confused :) and please tell me if I am writing into a wrong place! This place seems somewhat relevant.

To view, visit change 68162. To unsubscribe, or for help writing mail filters, visit settings.