Attention is currently required from: Namyoon Woo, Edward O'Callaghan.
Patch set 2:Code-Review +2
View Change
1 comment:
File dummyflasher.c:
Patch Set #2, Line 987: return 1;
There's lots of memory leaks here, e.g. `data` and `flashchip_contents`. Would be great to address them in a follow-up.
To view, visit change 54722. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I11dfe713dd2fecfd3981ab50e31c9215d00bc787
Gerrit-Change-Number: 54722
Gerrit-PatchSet: 2
Gerrit-Owner: Edward O'Callaghan <quasisec@chromium.org>
Gerrit-Reviewer: Anastasia Klimchuk <aklm@chromium.org>
Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: Namyoon Woo <namyoon@google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-Attention: Namyoon Woo <namyoon@google.com>
Gerrit-Attention: Edward O'Callaghan <quasisec@chromium.org>
Gerrit-Comment-Date: Sun, 23 May 2021 10:21:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment