>> This might make it more confusing for the moment, my goal would
>> be to have something like
>> flashrom -p internal --ifd -i bios:cbfs.bin --mode write #1
>> for individual regions, and
>> flashrom -p internal -i all:some.rom --mode write #2
>> for the whole flash, where
>> flashrom -p internal -w some.rom #3
>> would be a shorthand for #2.
> In any case, this is a step in the right direction by making full-sized filename optional. I'll be completely onboard if `flashrom -p internal --ifd -i bios:cbfs.bin -w` can be shorthand for #1 and `flashrom -p internal -i all:some.rom -w` can be shorthand for #2.

Well, I added a short form `-m` and a prefix check, so `-mw`
would work. `-w` does still ask for a file name.

Otherwise, we should should deprecate -w/-r/-E/-v to be consistent for the various use cases.

I thought about that, too. But the old syntax is really handy
when it comes to flashing full files :-/

View Change

1 comment:

To view, visit change 30979. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Idfba11ec9991aac423b07f68f7dc45e7bebbb06b
Gerrit-Change-Number: 30979
Gerrit-PatchSet: 2
Gerrit-Owner: Nico Huber <nico.h@gmx.de>
Gerrit-Reviewer: Arthur Heymans <arthur@aheymans.xyz>
Gerrit-Reviewer: David Hendricks <david.hendricks@gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h@gmx.de>
Gerrit-Reviewer: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-Comment-Date: Thu, 17 Jan 2019 20:05:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: David Hendricks <david.hendricks@gmail.com>
Gerrit-MessageType: comment