Edward O'Callaghan submitted this change.

View Change

Approvals: build bot (Jenkins): Verified Edward O'Callaghan: Looks good to me, approved
tests: Convert read chip tests to libflashrom API

As a part of effort to convert command line (and everything else)
to be libflashrom users, chip tests need to be converted as well.

TEST=ninja test

Change-Id: I4493d4f269595783830c39a720b0a8963eab9daa
Signed-off-by: Anastasia Klimchuk <aklm@chromium.org>
Reviewed-on: https://review.coreboot.org/c/flashrom/+/61138
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Edward O'Callaghan <quasisec@chromium.org>
---
M tests/chip.c
1 file changed, 11 insertions(+), 2 deletions(-)

diff --git a/tests/chip.c b/tests/chip.c
index 0ea3a35..962321f 100644
--- a/tests/chip.c
+++ b/tests/chip.c
@@ -225,12 +225,17 @@
setup_chip(&flashctx, &layout, &mock_chip, param);

const char *const filename = "read_chip.test";
+ unsigned long size = mock_chip.total_size * 1024;
+ unsigned char *buf = calloc(size, sizeof(unsigned char));

printf("Read chip operation started.\n");
- assert_int_equal(0, do_read(&flashctx, filename));
+ assert_int_equal(0, flashrom_image_read(&flashctx, buf, size));
+ assert_int_equal(0, write_buf_to_file(buf, size, filename));
printf("Read chip operation done.\n");

teardown(&layout);
+
+ free(buf);
}

void read_chip_with_dummyflasher_test_success(void **state)
@@ -249,14 +254,18 @@
setup_chip(&flashctx, &layout, &mock_chip, param_dup);

const char *const filename = "read_chip.test";
+ unsigned long size = mock_chip.total_size * 1024;
+ unsigned char *buf = calloc(size, sizeof(unsigned char));

printf("Read chip operation started.\n");
- assert_int_equal(0, do_read(&flashctx, filename));
+ assert_int_equal(0, flashrom_image_read(&flashctx, buf, size));
+ assert_int_equal(0, write_buf_to_file(buf, size, filename));
printf("Read chip operation done.\n");

teardown(&layout);

free(param_dup);
+ free(buf);
}

void write_chip_test_success(void **state)

To view, visit change 61138. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I4493d4f269595783830c39a720b0a8963eab9daa
Gerrit-Change-Number: 61138
Gerrit-PatchSet: 2
Gerrit-Owner: Anastasia Klimchuk <aklm@chromium.org>
Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: Edward O'Callaghan <quasisec@chromium.org>
Gerrit-Reviewer: Nico Huber <nico.h@gmx.de>
Gerrit-Reviewer: Thomas Heijligen <src@posteo.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-MessageType: merged