View Change

3 comments:

• File lspcon_i2c_spi.c:

  • Patch Set #4, Line 333: uint8_t command_byte1[] = { ROMADDR_BYTE1, (offset >> 8) & 0xff };

    Yes this can be done in a single write, I just want to separate them to make this clear. […]

    Ack

  • Patch Set #4, Line 406: 256

    Actually no, I have go through the code and looks like that applied to the send_command method event […]

    Sounds reasonable.

• File lspcon_i2c_spi.c:

  • Patch Set #5, Line 31: #define READ_SIZE 32

    Remove.

To view, visit change 39687. To unsubscribe, or for help writing mail filters, visit settings.