Attention is currently required from: Nico Huber, Edward O'Callaghan, Anastasia Klimchuk.
Patch set 1:Code-Review +1
View Change
1 comment:
File tests/layout.c:
Patch Set #1, Line 26: printf("Creating layout...");
nit: Print a space afterwards?
printf("Creating layout... ");
^
Otherwise, the next print is contiguous:
Creating layout...done
To view, visit change 56439. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I36a39505f8db508672cde5a848684a3a22f5ccc4
Gerrit-Change-Number: 56439
Gerrit-PatchSet: 1
Gerrit-Owner: Anastasia Klimchuk <aklm@chromium.org>
Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: Edward O'Callaghan <quasisec@chromium.org>
Gerrit-Reviewer: Nico Huber <nico.h@gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-Attention: Nico Huber <nico.h@gmx.de>
Gerrit-Attention: Edward O'Callaghan <quasisec@chromium.org>
Gerrit-Attention: Anastasia Klimchuk <aklm@chromium.org>
Gerrit-Comment-Date: Tue, 20 Jul 2021 08:37:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment