Edward O'Callaghan submitted this change.

View Change



3 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.

Approvals: build bot (Jenkins): Verified Sam McNally: Looks good to me, approved Anastasia Klimchuk: Looks good to me, approved Alexander Goncharov: Looks good to me, but someone else must approve
dummyflasher.c: Speed up programmer ops without delay

There is no need to perform delays for the dummyflasher as
there is no chipsets to settle down.

BUG=b:266014935
TEST=builds

Change-Id: I43411b6d1558d1a5da4c7508618f8a6ec6d9bf95
Signed-off-by: Edward O'Callaghan <quasisec@google.com>
Reviewed-on: https://review.coreboot.org/c/flashrom/+/72423
Reviewed-by: Sam McNally <sammc@google.com>
Reviewed-by: Anastasia Klimchuk <aklm@chromium.org>
Reviewed-by: Alexander Goncharov <chat@joursoir.net>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
---
M dummyflasher.c
1 file changed, 28 insertions(+), 0 deletions(-)

diff --git a/dummyflasher.c b/dummyflasher.c
index 93f183a..2bdd10c 100644
--- a/dummyflasher.c
+++ b/dummyflasher.c
@@ -919,6 +919,10 @@
return 0;
}

+static void dummy_nop_delay(const struct flashctx *flash, unsigned int usecs)
+{
+}
+
static const struct spi_master spi_master_dummyflasher = {
.map_flash_region = dummy_map,
.unmap_flash_region = dummy_unmap,
@@ -930,6 +934,7 @@
.read = default_spi_read,
.write_256 = dummy_spi_write_256,
.probe_opcode = dummy_spi_probe_opcode,
+ .delay = dummy_nop_delay,
};

static const struct par_master par_master_dummyflasher = {
@@ -943,6 +948,7 @@
.chip_writew = dummy_chip_writew,
.chip_writel = dummy_chip_writel,
.chip_writen = dummy_chip_writen,
+ .delay = dummy_nop_delay,
};

static const struct opaque_master opaque_master_dummyflasher = {
@@ -950,6 +956,7 @@
.read = dummy_opaque_read,
.write = dummy_opaque_write,
.erase = dummy_opaque_erase,
+ .delay = dummy_nop_delay,
};

static int init_data(const struct programmer_cfg *cfg,

To view, visit change 72423. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I43411b6d1558d1a5da4c7508618f8a6ec6d9bf95
Gerrit-Change-Number: 72423
Gerrit-PatchSet: 5
Gerrit-Owner: Edward O'Callaghan <quasisec@chromium.org>
Gerrit-Reviewer: Alexander Goncharov <chat@joursoir.net>
Gerrit-Reviewer: Anastasia Klimchuk <aklm@chromium.org>
Gerrit-Reviewer: Edward O'Callaghan <quasisec@chromium.org>
Gerrit-Reviewer: Sam McNally <sammc@google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-MessageType: merged