Stefan Tauner has uploaded this change for review.

View Change

fixup! Convert flashrom to git

Fix broken/one-off loop to restore file dates.
Explain what the sed program actually does because it is non-trivial.

Change-Id: Iff4021be49a9fab208b619c555b9f9e81f671ab8
---
M Makefile
1 file changed, 6 insertions(+), 5 deletions(-)

git pull ssh://review.coreboot.org:29418/flashrom refs/changes/25/21825/1

diff --git a/Makefile b/Makefile
index 9c3ed72..a649f38 100644
--- a/Makefile
+++ b/Makefile
@@ -1406,16 +1406,17 @@
 #	exported sources.
 	@echo "VERSION = $(VERSION)" > "$(EXPORTDIR)/flashrom-$(RELEASENAME)/Makefile.version"
 	@echo "MAN_DATE = $(MAN_DATE)" >> "$(EXPORTDIR)/flashrom-$(RELEASENAME)/Makefile.version"
-#	Restore modification date of all tracked files not marked
-#	'export-ignore' in .gitattributes. sed is required to filter out file
-#	names having the attribute set.
+#	Restore modification date of all tracked files not marked 'export-ignore' in .gitattributes.
+#	sed is required to filter out file names having the attribute set.
+#	The sed program saves the file name in the hold buffer and then checks if the respective value is 'set'.
+#	If so it ignores the rest of the program, which otherwise restores the file name and prints it.
 	@git ls-tree -r -z -t --full-name --name-only HEAD | \
 		git check-attr -z --stdin export-ignore | \
-		sed -zne 'x;n;n;/^set$$/{b};x;p' | \
+		sed -zne 'x;n;n;{/^set$$/b;};x;p;' | \
 		xargs -0 sh -c 'for f; do \
 			touch -d $$(git log --pretty=format:%cI -1 HEAD -- "$$f") \
 				"$(EXPORTDIR)/flashrom-$(RELEASENAME)/$$f"; \
-		done'
+		done' dummy_arg0
 
 export: _export
 	@echo "Exported $(EXPORTDIR)/flashrom-$(RELEASENAME)/"

To view, visit change 21825. To unsubscribe, visit settings.