Edward O'Callaghan has uploaded this change for review.
layout.h,c: Use 'false' over '0' for bool type
The field member 'included' is of type boolean and so keep to
using 'true, false' values over numerics like '0'. Get rid of
a unnecessary yet trivial tab at the end of layout.h while we
are here.
BUG=none
BRANCH=none
TEST=builds
Change-Id: Ib594de2834175482ae5e36d9dd354ef2555c53d5
Signed-off-by: Edward O'Callaghan <quasisec@google.com>
---
M layout.c
M layout.h
2 files changed, 3 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/43/48743/1
diff --git a/layout.c b/layout.c
index d80b01f..272912c 100644
--- a/layout.c
+++ b/layout.c
@@ -81,7 +81,7 @@
}
layout->entries[layout->num_entries].start = strtol(tstr1, (char **)NULL, 16);
layout->entries[layout->num_entries].end = strtol(tstr2, (char **)NULL, 16);
- layout->entries[layout->num_entries].included = 0;
+ layout->entries[layout->num_entries].included = false;
layout->entries[layout->num_entries].name = strdup(tempname);
if (!layout->entries[layout->num_entries].name) {
msg_gerr("Error adding layout entry: %s\n", strerror(errno));
@@ -205,7 +205,7 @@
for (i = 0; i < layout->num_entries; i++) {
free(layout->entries[i].name);
- layout->entries[i].included = 0;
+ layout->entries[i].included = false;
}
layout->num_entries = 0;
}
diff --git a/layout.h b/layout.h
index 8e4eb13..cceedd1 100644
--- a/layout.h
+++ b/layout.h
@@ -67,4 +67,4 @@
const struct romentry *layout_next_included_region(const struct flashrom_layout *, chipoff_t);
const struct romentry *layout_next_included(const struct flashrom_layout *, const struct romentry *);
-#endif /* !__LAYOUT_H__ */
+#endif /* !__LAYOUT_H__ */
To view, visit change 48743. To unsubscribe, or for help writing mail filters, visit settings.