Attention is currently required from: Subrata Banik, Angel Pons, Nikolai Artemiev.

View Change

1 comment:

• Commit Message:

  • Patch Set #2, Line 7: ichspi.c: Read chip ID and use it to identify chip

    > > Maybe we should just print a warning if >1 chip is detected? […]

    In flashrom.c the top level of the CFG is:
    ```
    @@ -915,7 +915,7 @@ int probe_flash(struct registered_master *mst, int startchip, struct flashctx *f
                 if (!w29ee011_can_override(flash->chip->name, chip_to_probe))
                     goto notfound;
     
    -        if (probe_func(flash) != 1)
    ```

    you could return '2' from this function to mean two chips found and handle it in the above.

    The actionable here, however, is likely just read the descriptor to find the number of flashes and print that when it is >0 (i.e., >1chip) but just assume the first chip.

To view, visit change 69195. To unsubscribe, or for help writing mail filters, visit settings.