Attention is currently required from: Angel Pons.

View Change

1 comment:

• Commit Message:

  • Patch Set #1, Line 8:

    
    This was missed because `uint32_t` is `unsigned int` in most cases.
    However, it is not the case for DJGPP 6.1.0 for some reason.
    

    > You got no response for a couple of days because I have been recovering from surgery WTF.. […]

    Last couple of weeks have been pretty painful :| I've just been on and off review unofficially to help Anastasia which probably made it even more unclear. Since I rarely -2 I erroneously assumed you figured something might be strange. Any ways, cheers Angel and sorry for any confusion as well. Things like it would have been easier if I was full time Flashrom and hanging on IRC but sadly I am not.

    I figured addr is of a specific length because of how it is decoded into precisely four unsigned bytes:

    ```
    	(addr >> 24) & 0xff,
    	(addr >> 16) & 0xff,
    	(addr >> 8) & 0xff,
    	(addr & 0xff)
    ```

    Is `blocklen` just unused or am I not seeing it?

To view, visit change 52473. To unsubscribe, or for help writing mail filters, visit settings.