Attention is currently required from: Edward O'Callaghan, Nikolai Artemiev.
Patch set 4:Code-Review +2
View Change
1 comment:
File flashchips.c:
Patch Set #1, Line 17583: ..IM
This only works with `..IM` chips; there are other variants such as `W25Q32JW.. […]
Ah, I see the datasheet now. Looks like IQ variants operate in Quad SPI mode by default: https://imgur.com/Xf4FLIv.png
ID 0x6016 is already supported, but I'm worried now: it seems to be shared between V (3.3V) and W (1.8V) parts. This can be a problem if someone relies on voltage values in flashchips entries.
To view, visit change 53946. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I7425e12658dd69c4ec8d3309dd591d09a935bb4d
Gerrit-Change-Number: 53946
Gerrit-PatchSet: 4
Gerrit-Owner: Nikolai Artemiev <nartemiev@google.com>
Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: Edward O'Callaghan <quasisec@chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter@mailbox.org>
Gerrit-Attention: Edward O'Callaghan <quasisec@chromium.org>
Gerrit-Attention: Nikolai Artemiev <nartemiev@google.com>
Gerrit-Comment-Date: Mon, 10 May 2021 08:03:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Angel Pons <th3fanbus@gmail.com>
Comment-In-Reply-To: Nikolai Artemiev <nartemiev@google.com>
Gerrit-MessageType: comment