Attention is currently required from: Edward O'Callaghan, Angel Pons, Nikolai Artemiev.

View Change

1 comment:

• File raiden_debug_spi.c:

  • Patch Set #1, Line 444: spi_config

    Could we just call the field `spi_master` too? I think that would make […]

    I did a search for spi_config in this file, this string is also used as a part of some enum values in `packet_id_type` enum, also there is a function `get_spi_config_v2`. But the function is working with spi data actually, read/write count fields.
    So renaming makes sense, in a separate patch, yes. And function name and enum values should stay the same, I think.

To view, visit change 57972. To unsubscribe, or for help writing mail filters, visit settings.