Attention is currently required from: Joseph Goh.

Patch set 2:Code-Review +1

View Change

3 comments:

• Patchset:

  • Patch Set #2:

    Thanks Joseph! You need to add a comment about model id (see my comment below) and that should be it.

• File flashchips.c:

  • Patch Set #2, Line 8772: MACRONIX_MX25L1605

    Nope, it is 0x2015 since the RDID command is used (probe_spi_rdid, see page 20).

    Thanks for explaining! I agree.

    Why I was initially confused is that ID MACRONIX_MX25L1605 from another chip is used. You need to add a comment to include/flashchips.h that this id also serves MX25V16066 (there are lots comments like this as examples).

  • Patch Set #2, Line 8802: 2700

    yep, 2.3V-2.7V works, but at a slower speed. […]

    I see, thanks!

To view, visit change 68278. To unsubscribe, or for help writing mail filters, visit settings.