Attention is currently required from: Patrick Georgi.

Felix Singer would like build bot (Jenkins) and Patrick Georgi to review this change.

View Change

test_build.sh: Improve robustness when dealing with empty $CC

Add quotes so that = knows what to compare, otherwise the shell
complains:

    ./test_build.sh: 16: [: =: unexpected operator

Change-Id: Ia289b31291949f5cbc11484b8f1a7cb7a49bd2bb
Signed-off-by: Patrick Georgi <pgeorgi@google.com>
Reviewed-on: https://review.coreboot.org/c/flashrom/+/67740
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Felix Singer <felixsinger@posteo.net>
---
M test_build.sh
1 file changed, 19 insertions(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/flashrom refs/changes/08/68008/1

diff --git a/test_build.sh b/test_build.sh
index d6d29ee..7a15c20 100755
--- a/test_build.sh
+++ b/test_build.sh
@@ -9,7 +9,7 @@
 		      BUSPIRATE_SPI DEDIPROG DEVELOPERBOX_SPI SATAMV LINUX_MTD LINUX_SPI IT8212		\
 		      CH341A_SPI DIGILENT_SPI JLINK_SPI"
 
-if [ $(basename "${CC}") = "ccc-analyzer" ] || [ -n "${COVERITY_OUTPUT}" ]; then
+if [ "$(basename "${CC}")" = "ccc-analyzer" ] || [ -n "${COVERITY_OUTPUT}" ]; then
 	is_scan_build_env=1
 fi
 

To view, visit change 68008. To unsubscribe, or for help writing mail filters, visit settings.